Merged
Conversation
vasco-santos
force-pushed
the
fix/require-json-objects
branch
from
5f44940 to
783f5c9
Compare
vasco-santos
requested review from
gobengo and
olizilla
and removed request for
gobengo and
olizilla
Member
Author
1 task
|
Out of curiosity, what is the plan for tags? |
olizilla
approved these changes
Sep 2, 2022
olizilla
left a comment
olizilla
left a comment
There was a problem hiding this comment.
I'm in favour of making this less flexible while we figure out what we really need.
Member
Author
We should spec TAGs, but for now there are not any use cases I am aware of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on sync convo, let's require JSON objects with CID and tag on each entry of the list.
We should spec TAGs, but I feel like we can start with this for now and consider big picture once we have more use cases