avoid potential corruption in hashMapInsert due to table-resize-on-GC

Joel Dice · Joel Dice · commit 5f4d86a70340 · 2008-08-11T15:20:12.000-06:00
diff --git a/src/util.cpp b/src/util.cpp
@@ -380,11 +380,12 @@ hashMapInsert(Thread* t, object map, object key, object value,
 
   unsigned index = h & (arrayLength(t, array) - 1);
 
-  object n = makeTriple(t, k, value, arrayBody(t, array, index));
+  object n = makeTriple(t, k, value, 0);
 
   array = hashMapArray(t, map);
   index = h & (arrayLength(t, array) - 1);
 
+  set(t, n, TripleThird, arrayBody(t, array, index));
   set(t, array, ArrayBody + (index * BytesPerWord), n);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -380,11 +380,12 @@ hashMapInsert(Thread* t, object map, object key, object value,`
`380`	`380`
`381`	`381`	`unsigned index = h & (arrayLength(t, array) - 1);`
`382`	`382`
`383`		`- object n = makeTriple(t, k, value, arrayBody(t, array, index));`
	`383`	`+ object n = makeTriple(t, k, value, 0);`
`384`	`384`
`385`	`385`	`array = hashMapArray(t, map);`
`386`	`386`	`index = h & (arrayLength(t, array) - 1);`
`387`	`387`
	`388`	`+ set(t, n, TripleThird, arrayBody(t, array, index));`
`388`	`389`	`set(t, array, ArrayBody + (index * BytesPerWord), n);`
`389`	`390`	`}`
`390`	`391`