Skip to content

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Sep 15, 2025

Proposed changes

Took the recording of each metric out of scraper.go and into record/<metrics type>_metric.go
For metrics which require recording the previous metrics like HTTPTotal, Location & Server Zone had to create a struct in each.

Created the below after removing the recording from scraper.go
collector/nginxplusreciever/record/

  • cahce_metrics.go
  • http_mertics.go
  • upstream_mertics.go
  • location_zone_mertics.go
  • server_zone_mertics.go
  • stream_mertics.go
  • ssl_mertics.go

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Sep 15, 2025
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 15, 2025
@aphralG aphralG marked this pull request as ready for review September 16, 2025 16:12
@aphralG aphralG requested a review from a team as a code owner September 16, 2025 16:12
@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Sep 17, 2025
@aphralG aphralG changed the base branch from add-attribute-to-request-metrics to main September 18, 2025 09:10
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 18, 2025
@aphralG aphralG merged commit d64abd2 into main Sep 19, 2025
60 of 66 checks passed
@aphralG aphralG deleted the refactor-plus-scraper branch September 19, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks documentation Improvements or additions to documentation v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants