avoid deleting unmanaged files during config apply #1338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
dhurley
approved these changes
Oct 14, 2025
aphralG
reviewed
Oct 15, 2025
| } | ||
|
|
||
| // if file is unmanaged skip deletion | ||
| if manifestFile.GetUnmanaged() { |
There was a problem hiding this comment.
Can unit tests be added to check this ?
There was a problem hiding this comment.
I'm working on refactoring the unit tests around DetermineFileActions and the manifest file to add more cases including this one, but since we need to patch this one fast I said I would add those updates in another PR after the patch is released
aphralG
approved these changes
Oct 16, 2025
aphralG
pushed a commit
that referenced
this pull request
Oct 20, 2025
sean-breen
added a commit
that referenced
this pull request
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When determining the file actions during a config apply, we must track the file's
Unmanagedstatus in the manifest file when it is passed from the Mgmt plane, in order to avoid deleting these unmanaged files.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)