Skip to content

Set GOPROXY conditionally #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 23, 2025
Merged

Set GOPROXY conditionally #1356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
32b9986
add configure-goproxy action
sean-breen Oct 21, 2025
382bd6c
update conditions
sean-breen Oct 21, 2025
a77def5
fix path to local action
sean-breen Oct 21, 2025
14d0e51
add env vars
sean-breen Oct 22, 2025
5efa080
use with instead of env
sean-breen Oct 22, 2025
ba5c40d
fix path
sean-breen Oct 22, 2025
1569c08
use correct variable names
sean-breen Oct 22, 2025
a610d34
add url input
sean-breen Oct 22, 2025
433602a
try check for zero length
sean-breen Oct 22, 2025
61eeea7
fix condition
sean-breen Oct 22, 2025
60cbf70
comparison with quotes
sean-breen Oct 22, 2025
e6dcb39
missing quotes
sean-breen Oct 22, 2025
1c78f8e
add goproxy to every ci job
sean-breen Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .github/actions/configure-goproxy/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
name: configure-goproxy
author: s.breen
description: Sets the current Go module proxy based on the presence of a private proxy URL in secrets
inputs:
user:
description: Artifactory username secret name
required: false
default: ""
token:
description: Artifactory token secret name
required: false
default: ""
url:
description: Artifactory URL
required: false
default: ""
runs:
using: 'composite'
steps:
- name: Configure Go Proxy
id: configure-goproxy
shell: bash
run: |
if [[ -z "${{ inputs.user }}" ]] || \
[[ -z "${{ inputs.token }}" ]] || \
[[ -z "${{ inputs.url }}" ]] || \
[[ "${{ github.event.pull_request.head.repo.fork }}" == 'true' ]] ||
[[ "${{ startsWith(github.head_ref, 'dependabot-')}}" == 'true' ]] ; then
echo "No Artifactory secrets available - using direct GOPROXY"
GOPROXY_VALUE="direct"
else
echo "Development mode - using dev Artifactory"
GOPROXY_VALUE="https://${{ inputs.user }}:${{ inputs.token }}@${{ inputs.url }}"
fi
echo "GOPROXY=${GOPROXY_VALUE}" >> $GITHUB_ENV

74 changes: 70 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ permissions:

env:
NFPM_VERSION: 'v2.35.3'
GOPROXY: "https://${{ secrets.ARTIFACTORY_USER }}:${{ secrets.ARTIFACTORY_TOKEN }}@azr.artifactory.f5net.com/artifactory/api/go/f5-nginx-go-dev"
GOPROXY: "direct"

jobs:
proxy-sanity-check:
name: Proxy Sanity Check
runs-on: ubuntu-22.04
if: ${{ !github.event.pull_request.head.repo.fork && !startsWith(github.head_ref, 'dependabot-') }}
env:
GOPROXY: "https://${{ secrets.ARTIFACTORY_USER }}:${{ secrets.ARTIFACTORY_TOKEN }}@azr.artifactory.f5net.com/artifactory/api/go/f5-nginx-go-dev"
GOPROXY: "https://${{ secrets.ARTIFACTORY_USER }}:${{ secrets.ARTIFACTORY_TOKEN }}@${{ secrets.ARTIFACTORY_URL_DEV }}"
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
Expand All @@ -46,6 +46,12 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Configure Go Proxy
uses: ./.github/actions/configure-goproxy
with:
user: ${{ secrets.ARTIFACTORY_USER }}
token: ${{ secrets.ARTIFACTORY_TOKEN }}
url: ${{ secrets.ARTIFACTORY_URL_DEV }}
- uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
with:
go-version-file: 'go.mod'
Expand All @@ -62,6 +68,12 @@ jobs:
contents: write
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Configure Go Proxy
uses: ./.github/actions/configure-goproxy
with:
user: ${{ secrets.ARTIFACTORY_USER }}
token: ${{ secrets.ARTIFACTORY_TOKEN }}
url: ${{ secrets.ARTIFACTORY_URL_DEV }}
- uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
with:
go-version-file: 'go.mod'
Expand All @@ -79,6 +91,12 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Configure Go Proxy
uses: ./.github/actions/configure-goproxy
with:
user: ${{ secrets.ARTIFACTORY_USER }}
token: ${{ secrets.ARTIFACTORY_TOKEN }}
url: ${{ secrets.ARTIFACTORY_URL_DEV }}
- uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
with:
go-version-file: 'go.mod'
Expand All @@ -93,6 +111,12 @@ jobs:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
fetch-tags: 'true'
- name: Configure Go Proxy
uses: ./.github/actions/configure-goproxy
with:
user: ${{ secrets.ARTIFACTORY_USER }}
token: ${{ secrets.ARTIFACTORY_TOKEN }}
url: ${{ secrets.ARTIFACTORY_URL_DEV }}
- uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
with:
go-version-file: 'go.mod'
Expand Down Expand Up @@ -124,6 +148,12 @@ jobs:
version: "3.22"
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Configure Go Proxy
uses: ./.github/actions/configure-goproxy
with:
user: ${{ secrets.ARTIFACTORY_USER }}
token: ${{ secrets.ARTIFACTORY_TOKEN }}
url: ${{ secrets.ARTIFACTORY_URL_DEV }}
- uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
with:
go-version-file: 'go.mod'
Expand Down Expand Up @@ -168,6 +198,12 @@ jobs:
version: "3.22"
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Configure Go Proxy
uses: ./.github/actions/configure-goproxy
with:
user: ${{ secrets.ARTIFACTORY_USER }}
token: ${{ secrets.ARTIFACTORY_TOKEN }}
url: ${{ secrets.ARTIFACTORY_URL_DEV }}
- uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
with:
go-version-file: 'go.mod'
Expand Down Expand Up @@ -219,6 +255,12 @@ jobs:
release: "alpine"
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Configure Go Proxy
uses: ./.github/actions/configure-goproxy
with:
user: ${{ secrets.ARTIFACTORY_USER }}
token: ${{ secrets.ARTIFACTORY_TOKEN }}
url: ${{ secrets.ARTIFACTORY_URL_DEV }}
- uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
with:
go-version-file: 'go.mod'
Expand Down Expand Up @@ -280,6 +322,12 @@ jobs:
path: "/nginx-plus/agent"
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Configure Go Proxy
uses: ./.github/actions/configure-goproxy
with:
user: ${{ secrets.ARTIFACTORY_USER }}
token: ${{ secrets.ARTIFACTORY_TOKEN }}
url: ${{ secrets.ARTIFACTORY_URL_DEV }}
- uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
with:
go-version-file: 'go.mod'
Expand Down Expand Up @@ -339,7 +387,13 @@ jobs:
version: "mainline"
release: "alpine"
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Configure Go Proxy
uses: ./.github/actions/configure-goproxy
with:
user: ${{ secrets.ARTIFACTORY_USER }}
token: ${{ secrets.ARTIFACTORY_TOKEN }}
url: ${{ secrets.ARTIFACTORY_URL_DEV }}
- uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
with:
go-version-file: 'go.mod'
Expand Down Expand Up @@ -400,7 +454,13 @@ jobs:
release: "debian"
path: "/nginx-plus/agent"
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Configure Go Proxy
uses: ./.github/actions/configure-goproxy
with:
user: ${{ secrets.ARTIFACTORY_USER }}
token: ${{ secrets.ARTIFACTORY_TOKEN }}
url: ${{ secrets.ARTIFACTORY_URL_DEV }}
- uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
with:
go-version-file: 'go.mod'
Expand Down Expand Up @@ -446,6 +506,12 @@ jobs:
contents: write
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Configure Go Proxy
uses: ./.github/actions/configure-goproxy
with:
user: ${{ secrets.ARTIFACTORY_USER }}
token: ${{ secrets.ARTIFACTORY_TOKEN }}
url: ${{ secrets.ARTIFACTORY_URL_DEV }}
- uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
with:
go-version-file: 'go.mod'
Expand Down
Loading