Skip to content

Conversation

@aphralG
Copy link
Contributor

@aphralG aphralG commented Nov 10, 2025

Proposed changes

Remove allowed directories check from additional OTel config paths provided in the Agent config

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Nov 10, 2025
@aphralG aphralG requested a review from a team as a code owner November 10, 2025 11:08
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.30%. Comparing base (61f1fc8) to head (341a6ed).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1380      +/-   ##
==========================================
+ Coverage   86.29%   86.30%   +0.01%     
==========================================
  Files         102      102              
  Lines       12580    12575       -5     
==========================================
- Hits        10856    10853       -3     
+ Misses       1248     1247       -1     
+ Partials      476      475       -1     
Files with missing lines Coverage Δ
internal/config/types.go 87.65% <ø> (+1.60%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f1fc8...341a6ed. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aphralG aphralG changed the title OtRemove allowed directories check on additional OTel config paths Remove allowed directories check on additional OTel config paths Nov 10, 2025
@dhurley dhurley merged commit 34a13e6 into main Nov 11, 2025
96 of 97 checks passed
@dhurley dhurley deleted the remove-allowed-dir-check-otel-config branch November 11, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants