Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR I mentioned I was working up on docker-library/official-images#197.
Overall, this is a really simple
Dockerfile, and I totally dig it. The hack with just making symlinks for the access log and error log is perfect!I've tried to split this out into logical chunks with my commits so it's easier to review each change individually if you prefer. I'm also happy to amend or make separate PRs if that's preferable. The one that's the most important is d5b14ea, but I'm copying each commit description here to hopefully make them easier to read over.
e683580 Update "apt-key" usage to verify the fingerprint
27ced27 Use same symlink logic for stderr as stdout
305e286 Simplify default command via PATH and default conf
d5b14ea Add explicit version pinning, for cache-busting
Also, if you'd be interested in maintaining "stable" versions too, or even just in having this version number easy to update (see
update.shandgenerate-stackbrew-library.shin the postgres repo for examples of what I mean), I'd be happy to send a PR setting that kind of thing up so you could have both "1.6" and "1.7" easily, and keep them both updated easily as well. We're happy to be as involved in that as you'd like us to be.