Skip to content

fix: remove redundant/unused image tags #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 17, 2025
Merged

fix: remove redundant/unused image tags #1451

merged 4 commits into from
Nov 17, 2025

Conversation

@balakoteswar
Copy link
Contributor

@balakoteswar balakoteswar commented Nov 17, 2025

Proposed changes

  • This pull request is to remove redundant/unused image tags from values.yaml file for NIM deployment.
  • Also, added commented help for enabling OpenShift deployment via values.yaml

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩

@balakoteswar balakoteswar self-assigned this Nov 17, 2025
@balakoteswar balakoteswar requested a review from a team as a code owner November 17, 2025 08:39
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nim Issues related to NGINX Instance Manager labels Nov 17, 2025
@github-actions
Copy link

github-actions bot commented Nov 17, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/1451/

JTorreG
JTorreG reviewed Nov 17, 2025
View reviewed changes
JTorreG
JTorreG approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@JTorreG JTorreG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with 1 nit

balakoteswar and others added 2 commits November 17, 2025 21:34
@balakoteswar balakoteswar merged commit 8c4e4b0 into main Nov 17, 2025
9 checks passed
@balakoteswar balakoteswar deleted the k8-docs-nim branch November 17, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JTorreG JTorreG JTorreG approved these changes

@mjang mjang mjang approved these changes

@travisamartin travisamartin Awaiting requested review from travisamartin

Assignees

@balakoteswar balakoteswar

Labels

documentation Improvements or additions to documentation product/nim Issues related to NGINX Instance Manager

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@balakoteswar @mjang @JTorreG