Skip to content

feat: Update NGINX App Protect docker build commands #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2025
Merged

feat: Update NGINX App Protect docker build commands #443

merged 2 commits into from
Apr 23, 2025

Conversation

ADubhlaoich
Copy link
Member

@ADubhlaoich ADubhlaoich commented Apr 23, 2025 •
edited
Loading

Proposed changes

This pull request updates instances of docker build commands across the NGINX App Protect WAF & DoS documentation sets to append a platform parameter. Without it, Docker attempts to look for packages based on the architecture of the system you're building the image on.

Closes #394

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@ADubhlaoich
feat: Update NGINX App Protect docker build commands
1bb9033 
This commit updates instances of docker build commands across the NGINX
App Protect WAF & DoS documentation sets to append a platform parameter.
Without it, Docker attempts to look for packages based on the
architecture of the system you're building the image on.
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner April 23, 2025 15:35
@github-actions github-actions bot added documentation Improvements or additions to documentation product/dos Issues related to F5 DoS for NGINX product/waf Issues related to F5 WAF for NGINX labels Apr 23, 2025
@ADubhlaoich ADubhlaoich self-assigned this Apr 23, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/443/

@rnitzan rnitzan self-requested a review April 23, 2025 15:44
@ADubhlaoich ADubhlaoich force-pushed the nap/fix-docker-commands branch from 2fedb26 to 542515d Compare April 23, 2025 16:05
mjang
mjang approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trying to learn how this all works -- Is it too soon to start deleting unsupported versions of OSes?

Or is Ubuntu 18.04 just deprecated?

Screenshot 2025-04-23 at 9 17 50 AM

@ADubhlaoich
Copy link
Member Author

@mjang Outside of scope for the PR, but there's some drift in the documentation right now with some of the supported OS content that needs to be phased out.

It'll be handled as its own PR, since there's lots of inconsistency at the moment.

@ADubhlaoich ADubhlaoich merged commit 26173a2 into main Apr 23, 2025
9 checks passed
@ADubhlaoich ADubhlaoich deleted the nap/fix-docker-commands branch April 23, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjang mjang mjang approved these changes

@rnitzan rnitzan rnitzan approved these changes

@JTorreG JTorreG JTorreG approved these changes

Assignees

@ADubhlaoich ADubhlaoich

Labels

documentation Improvements or additions to documentation product/dos Issues related to F5 DoS for NGINX product/waf Issues related to F5 WAF for NGINX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NAP-WAF : docker builds fail to find app protect packages

4 participants

@ADubhlaoich @mjang @rnitzan @JTorreG