Skip to content

Conversation

@bavshin-f5
Copy link
Member

See 1141c24 for details.
I don't have the solution for linking issues yet, but we still can run the tests with the oldest supported compiler.

@bavshin-f5 bavshin-f5 requested review from Copilot and xeioex November 4, 2025 20:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new CI workflow step to run unit tests specifically with the MSRV (Minimum Supported Rust Version) toolchain, addressing linking issues that occur with Rust >= 1.89.

Key Changes:

  • Adds a conditional unit test execution step that only runs when using the MSRV toolchain
  • Ensures unit tests are skipped on newer Rust versions where linking issues exist

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bavshin-f5 bavshin-f5 merged commit afd40f0 into nginx:main Nov 4, 2025
20 checks passed
@bavshin-f5 bavshin-f5 deleted the unittest branch November 4, 2025 21:58
@bavshin-f5 bavshin-f5 added this to the 0.3.0 milestone Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants