helm: Service type is hard-coded as ClusterIP.

[eddiewebb]

Describe the bug
The docs say without specifying that the Service.type default is LoadBalancer.

On running this in EKS I noticed no load balancer. THe Service spec only has a CLuster IP. Digging into the tempaltes I see it hard-coded, and makes no use of service.type anywhere in chart templates.

https://github.com/nginx/nginx-gateway-fabric/blob/v2.2.0/charts/nginx-gateway-fabric/templates/service.yaml#L16

To Reproduce
Steps to reproduce the behavior:

1. use helm chart
2. Attempt to deploy as loadbalancer
3. serivce type clusterIP results.

Expected behavior
Template should use service.type in https://github.com/nginx/nginx-gateway-fabric/blob/v2.2.0/charts/nginx-gateway-fabric/templates/service.yaml#L16

Your environment

• Version of the NGINX Gateway Fabric - release version or a specific commit. The first line of the nginx-gateway container logs includes the commit info.
• Version of Kubernetes
• Kubernetes platform (e.g. Mini-kube or GCP)
• Details on how you expose the NGINX Gateway Fabric Pod (e.g. Service of type LoadBalancer or port-forward)
• Logs of NGINX container: kubectl -n <nginx-deployment-namespace> logs deployments/<nginx-deployment>
• NGINX Configuration: kubectl -n <nginx-deployment-namespace> exec -it deployments/<nginx-deployment> -- nginx -T

Additional context

kubectl describe svc -n nginx-gateway
Name:                     nginx-gateway-nginx-gateway-fabric
Namespace:                nginx-gateway
Labels:                   app.kubernetes.io/instance=nginx-gateway
                          app.kubernetes.io/managed-by=Helm
                          app.kubernetes.io/name=nginx-gateway-fabric
                          app.kubernetes.io/version=2.2.1
                          helm.sh/chart=nginx-gateway-fabric-2.2.1
Annotations:              meta.helm.sh/release-name: nginx-gateway
                          meta.helm.sh/release-namespace: nginx-gateway
Selector:                 app.kubernetes.io/instance=nginx-gateway,app.kubernetes.io/name=nginx-gateway-fabric
Type:                     ClusterIP
IP Family Policy:         SingleStack
IP Families:              IPv4
IP:                       xx.xx.xx.xx
IPs:                      xx.xx.xx.xx
Port:                     agent-grpc  443/TCP
TargetPort:               8443/TCP
Endpoints:                10.0.12.127:8443
Session Affinity:         None
Internal Traffic Policy:  Cluster
Events:                   <none>

[nginx-bot]

Hi @eddiewebb! Welcome to the project! 🎉

Thanks for opening this issue!
Be sure to check out our Contributing Guidelines and the Issue Lifecycle while you wait for someone on the team to take a look at this.

[eddiewebb]

621ec00 shows the change that dropped respect for service.type

[sjberman]

Hi @eddiewebb, the ClusterIP Service you linked is the Service for the controller, not the NGINX data plane.

Client traffic flows to the NGINX Service, which is provisioned by the controller when a Gateway is created, and by default is of type LoadBalancer. nginx.service.type

[eddiewebb]

@sjberman thank you for clarifying.

Can the docs reflect this change?

By default, the NGINX Gateway Fabric helm chart deploys a LoadBalancer Service.

But with this model the default helm chart will not deploy any LB until a gateway is declared.

THe "accessing" section should explain this further.
https://docs.nginx.com/nginx-gateway-fabric/install/helm/#access-nginx-gateway-fabric

[sjberman]

@eddiewebb Yes, that doc should definitely be made clearer. Thanks for pointing that out.

[sjberman]

nginx/documentation#1440