Add status to snippetsFilter #2536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-osborn
suggested changes
Sep 11, 2024
bjee19
requested changes
Sep 11, 2024
kate-osborn
approved these changes
Sep 12, 2024
|
nit: @salonichf5 , can you update the PR to use |
bjee19
requested changes
Sep 12, 2024
salonichf5
force-pushed
the
feat/status-snippets
branch
from
7cc5fb6 to
6ae93f8
Compare
salonichf5
force-pushed
the
feat/status-snippets
branch
from
6ae93f8 to
49ec411
Compare
salonichf5
merged commit 9c360dd
into
nginx:feature/snippets-filter
23 of 24 checks passed
kate-osborn
pushed a commit
that referenced
this pull request
Sep 24, 2024
Add Status to SnippetsFilter Problem: Users want to be have information about the status of the snippetFilters. Solution: Add status details to snippetFilters.
salonichf5
added a commit
that referenced
this pull request
Oct 8, 2024
Add Status to SnippetsFilter Problem: Users want to be have information about the status of the snippetFilters. Solution: Add status details to snippetFilters.
salonichf5
added a commit
that referenced
this pull request
Oct 8, 2024
Add Status to SnippetsFilter Problem: Users want to be have information about the status of the snippetFilters. Solution: Add status details to snippetFilters.
sjberman
pushed a commit
that referenced
this pull request
Oct 8, 2024
Add Status to SnippetsFilter Problem: Users want to be have information about the status of the snippetFilters. Solution: Add status details to snippetFilters.
salonichf5
added a commit
that referenced
this pull request
Oct 8, 2024
Add Status to SnippetsFilter Problem: Users want to be have information about the status of the snippetFilters. Solution: Add status details to snippetFilters.
sjberman
pushed a commit
that referenced
this pull request
Oct 9, 2024
Add Status to SnippetsFilter Problem: Users want to be have information about the status of the snippetFilters. Solution: Add status details to snippetFilters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Users want to be have information about the status of the snippetFilters.
Solution: Add status details to snippetFilters.
Testing: Unit Tests
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #2416
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.