Skip to content

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Problem: The advanced routing guide in the documentation is being updated to include an example for regex path type so we need to update our examples to reflect this

Solution: Add the new regex route yaml corresponding to the guide

Closes #3946

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@ciarams87 ciarams87 requested a review from a team as a code owner October 15, 2025 08:20
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 15, 2025
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.51%. Comparing base (1c3bf8e) to head (94773df).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4073      +/-   ##
==========================================
- Coverage   86.53%   86.51%   -0.02%     
==========================================
  Files         131      131              
  Lines       17796    17796              
  Branches       74       74              
==========================================
- Hits        15399    15397       -2     
- Misses       2197     2199       +2     
  Partials      200      200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shaun-nx
Copy link
Contributor

@ciarams87 would it be better to add this new HTTPRoute to cafe-routes.yaml as that already has two HTTPRoutes in there for different routing scenarios?

@ciarams87 ciarams87 force-pushed the docs/update-advanced-routing branch from 562de83 to e507532 Compare October 21, 2025 08:18
@ciarams87 ciarams87 force-pushed the docs/update-advanced-routing branch from e507532 to 100bd86 Compare October 21, 2025 08:49
@ciarams87 ciarams87 enabled auto-merge (squash) October 21, 2025 09:17
@ciarams87 ciarams87 force-pushed the docs/update-advanced-routing branch from 100bd86 to 94773df Compare October 21, 2025 09:26
@ciarams87 ciarams87 merged commit 6eb79b2 into main Oct 21, 2025
60 checks passed
@ciarams87 ciarams87 deleted the docs/update-advanced-routing branch October 21, 2025 09:56
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Update Advanced routing guide to include Regex path matching example

5 participants