Skip to content

Upload NFR test results even if test fails #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

Upload NFR test results even if test fails #4112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/nfr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ jobs:
run: make create-gke-router || true

- name: Run Tests
continue-on-error: true
working-directory: ./tests
run: |
if ${{ needs.vars.outputs.test_label != 'all' }}; then
Expand Down
12 changes: 7 additions & 5 deletions tests/scripts/run-tests-gcp-vm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,7 @@ gcloud compute ssh --zone "${GKE_CLUSTER_ZONE}" --project="${GKE_PROJECT}" usern
bash -s" <"${SCRIPT_DIR}"/remote-scripts/run-nfr-tests.sh
retcode=$?

if [ ${retcode} -ne 0 ]; then
echo "Error running tests on VM"
exit 1
fi

## Download results regardless of test outcome (needed for debugging failures)
## Use rsync if running locally (faster); otherwise if in the pipeline don't download an SSH config
if [ "${CI}" = "false" ]; then
gcloud compute config-ssh --ssh-config-file ngf-gcp.ssh >/dev/null
Expand All @@ -28,6 +24,12 @@ else
gcloud compute scp --zone "${GKE_CLUSTER_ZONE}" --project="${GKE_PROJECT}" --recurse username@"${RESOURCE_NAME}":~/nginx-gateway-fabric/tests/results .
fi

## Exit with error code after downloading results if tests failed
if [ ${retcode} -ne 0 ]; then
echo "Error running tests on VM"
exit 1
fi

## If tearing down the longevity test, we need to collect logs from gcloud and add to the results
if [ "${STOP_LONGEVITY}" = "true" ]; then
version=${NGF_VERSION}
Expand Down
Loading