Skip to content

Conversation

@ciarams87
Copy link
Contributor

Proposed changes

Problem: Helm local tests are failing in the release branch

Solution: Add the correct docker tags meta for release branch, and add tag input for production release. Also fixed a bug where we would have a double v in the tag name for build images checkout on the production release

Cherry-pick of #4126

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.51%. Comparing base (7382a92) to head (55ca2a3).
⚠️ Report is 1 commits behind head on release-2.2.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.2    #4130      +/-   ##
===============================================
- Coverage        86.51%   86.51%   -0.01%     
===============================================
  Files              131      131              
  Lines            17796    17796              
  Branches            74       74              
===============================================
- Hits             15397    15396       -1     
  Misses            2199     2199              
- Partials           200      201       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciarams87 ciarams87 added this to the v2.2.0 milestone Oct 22, 2025
@ciarams87 ciarams87 added the helm-chart Relates to helm chart label Oct 22, 2025
@ciarams87 ciarams87 merged commit ca08060 into release-2.2 Oct 22, 2025
61 checks passed
@ciarams87 ciarams87 deleted the cp/helm branch October 22, 2025 09:10
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

helm-chart Relates to helm chart

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants