Skip to content

Conversation

@ciarams87
Copy link
Contributor

Proposed changes

Cherry-pick of #4182

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Preserve external controller annotations.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.12%. Comparing base (b3fdc43) to head (58a35e8).
⚠️ Report is 3 commits behind head on release-2.2.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.2    #4238      +/-   ##
===============================================
+ Coverage        86.11%   86.12%   +0.01%     
===============================================
  Files              131      131              
  Lines            14257    14282      +25     
  Branches            74       74              
===============================================
+ Hits             12277    12301      +24     
  Misses            1777     1777              
- Partials           203      204       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman added the bug Something isn't working label Nov 7, 2025
@github-actions github-actions bot removed the bug Something isn't working label Nov 10, 2025
@ciarams87 ciarams87 merged commit e7af3a5 into release-2.2 Nov 10, 2025
62 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Nov 10, 2025
@ciarams87 ciarams87 deleted the cp/ext-annotations branch November 10, 2025 16:48
@sjberman sjberman added the bug Something isn't working label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working release-notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants