-
Notifications
You must be signed in to change notification settings - Fork 142
Add a loadBalancingMethod field to the Upstream Settings Policy API #4251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a loadBalancingMethod field to the Upstream Settings Policy API #4251
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/session-persistence #4251 +/- ##
============================================================
+ Coverage 86.11% 86.13% +0.01%
============================================================
Files 131 131
Lines 14205 14205
Branches 35 35
============================================================
+ Hits 12233 12235 +2
+ Misses 1768 1766 -2
Partials 204 204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fef5236 to
588c0a5
Compare
sjberman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind updating the PR title to be more descriptive about what you're actually updating?
loadBalancingMethod field to the Upstream Settings Policy API
loadBalancingMethod field to the Upstream Settings Policy API588c0a5 to
a03330c
Compare
985d2ff to
6fa5e7d
Compare
…4251) Problem: Users want to specify load balancing method via Upstream Settings Policy API Solution: Extend Upstream settings policy API to support load balancing method field.
…4251) Problem: Users want to specify load balancing method via Upstream Settings Policy API Solution: Extend Upstream settings policy API to support load balancing method field.
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Users want to specify load balancing method via Upstream Settings Policy API
Solution: Extend Upstream settings policy API to support load balancing method field.
Testing: Manual testing applying CRDs
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #4229
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.