Skip to content

Conversation

@ciarams87
Copy link
Contributor

Proposed changes

Problem: The conformance profiles are not being correctly uploaded to the GitHub release

Solution: Update the release upload command to use the inputs.release_version instead of the branch name

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@ciarams87 ciarams87 requested a review from a team as a code owner November 13, 2025 23:53
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.08%. Comparing base (ab8263a) to head (0df91fe).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4289      +/-   ##
==========================================
+ Coverage   86.05%   86.08%   +0.03%     
==========================================
  Files         132      132              
  Lines       14342    14342              
  Branches       35       35              
==========================================
+ Hits        12342    12347       +5     
+ Misses       1794     1792       -2     
+ Partials      206      203       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciarams87 ciarams87 force-pushed the chore/fix-conf-profile branch from 2bce1e0 to 0df91fe Compare November 14, 2025 08:44
@ciarams87 ciarams87 merged commit 7899925 into main Nov 14, 2025
61 checks passed
@ciarams87 ciarams87 deleted the chore/fix-conf-profile branch November 14, 2025 10:57
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants