Skip to content

Conversation

@shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Dec 5, 2025

Proposed changes

This change ensures that the gateway binary that we copy to /usr/bin/gateway in our UBI Control Plane Dockerfile has the appropriate permissions to run.

Currently, this causes an error in our UBI deployments that prevents the certificate generator pod from running.

Closes #4405

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Fix permission issue with nginx-gateway container for UBI 

@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 5, 2025
@sjberman
Copy link
Collaborator

sjberman commented Dec 5, 2025

Can you create an issue associated with this?

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.12%. Comparing base (c2a4813) to head (32c4f80).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4404   +/-   ##
=======================================
  Coverage   86.12%   86.12%           
=======================================
  Files         132      132           
  Lines       14381    14381           
  Branches       35       35           
=======================================
  Hits        12386    12386           
  Misses       1785     1785           
  Partials      210      210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman
Copy link
Collaborator

sjberman commented Dec 5, 2025

Also, in the release note, I'd update this to say nginx-gateway container, because the same binary is used for both the cert-generator job and the main controller.

@sjberman sjberman added bug Something isn't working and removed chore Pull requests for routine tasks labels Dec 5, 2025
@shaun-nx shaun-nx merged commit 7b55423 into main Dec 5, 2025
61 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Dec 5, 2025
@shaun-nx shaun-nx deleted the chore/cert-generator-permissions branch December 5, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working release-notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

NGF v2.2.1 not running on OpenShift

5 participants