Removed legacy charset directive from default config example. #829
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The use of the de facto legacy koi8-r charset, which is specific to Cyrillic encoding, On the other side, the need to explicitly set utf-8 in Content-Type is vague. |
Please update according to the style.
|
MohamedKarrab
changed the title
MohamedKarrab
changed the title
|
Ok it's done. |
The example configuration previously specified 'charset koi8-r', which is a legacy Cyrillic encoding. As koi8-r is rarely used today and modern browsers handle UTF-8 by default, specifying the charset explicitly is unnecessary. Removing the directive keeps the example configuration concise and aligned with current best practices.
pluknet
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example configuration previously specified charset koi8-r, a legacy Cyrillic encoding. As koi8-r is rarely used today and modern browsers handle UTF-8 by default, explicitly specifying the charset is unnecessary.
Proposed changes
This change removes the directive from the default nginx.conf, keeping the example concise and aligned with current best practices.
If this pull request addresses an issue on GitHub, make sure to reference that
issue using one of the
supported keywords.
Before creating a pull request, make sure to comply with the
Contributing Guidelines.