HTTP CONNECT infrastructure #935
Merged
+148
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluknet
reviewed
Oct 22, 2025
| if (ngx_str7_cmp(m, 'C', 'O', 'N', 'N', 'E', 'C', 'T', ' ')) | ||
| { | ||
| r->method = NGX_HTTP_CONNECT; | ||
| state = sw_spaces_before_host; |
There was a problem hiding this comment.
You may want to add break statement there, see also 0a6efee
There was a problem hiding this comment.
If only for symmetry in case we add one for the OPTIONS as well. Otherwise it does not seem to make sense.
|
I think we may need to resurrect $is_request_port for constructs with optional port (such as other than in CONNECT), to make the following possible: proxy_set_header Host $host$is_request_port$request_port; (see also PR 236 as such an example) |
pluknet
approved these changes
Oct 22, 2025
The $request_port variable contains the port passed by the client in the request line (for HTTP/1.x) or ":authority" pseudo-header (for HTTP/2 and HTTP/3). If the request line contains no host, or ":authority" is missing, then $request_port is taken from the "Host" header, similar to the $host variable. The $is_request_port variable contains ":" if $request_port is non-empty, and is empty otherwise.
The change allows modules to use the CONNECT method with HTTP/1.1 requests. To do so, they need to set the "allow_connect" flag in the core server configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the
$request_portvariable for HTTP request, followed by the infrastructure for HTTP CONNECT method.