Skip to content

publish to crates.io #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2023
Merged

publish to crates.io #27

merged 3 commits into from
May 17, 2023

Conversation

@ivanitskiy
Copy link
Contributor

@ivanitskiy ivanitskiy commented May 16, 2023 •
edited
Loading

Proposed changes

Prepare crates to be published to crates.io:

  • updated Cargo.toml and added missing fields that are required for publishing to crates.io
  • updated documentation
  • updated bindgen to "0.65.0"
  • added repostatus and crates badges

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ivanitskiy ivanitskiy requested review from dekobon and f5yacobucci May 16, 2023 19:42
@ivanitskiy
Copy link
Contributor Author

ivanitskiy commented May 16, 2023

to locally preview documentation: cargo doc -r --open -p ngx

@ivanitskiy ivanitskiy changed the title Prepare publish publish to crates.io May 16, 2023
@ivanitskiy ivanitskiy mentioned this pull request May 16, 2023
Closed
dekobon
dekobon approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@dekobon dekobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ivanitskiy ivanitskiy merged commit dd687a4 into nginx:master May 17, 2023
@ivanitskiy ivanitskiy deleted the prepare-publish branch May 17, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dekobon dekobon dekobon approved these changes

@f5yacobucci f5yacobucci Awaiting requested review from f5yacobucci

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ivanitskiy @dekobon