Skip to content

Conversation

@alessfg
Copy link
Member

@alessfg alessfg commented Mar 25, 2025

Proposed changes

As of right now, the image cleanup workflow runs weekly and promptly deletes any untagged images in AWS ECR and GHCR. This PR tweaks the workflow to only delete images that are over two years old. The frequency can be adjusted down the line if deemed necessary.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • I have run ./update.sh and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
  • I have tested that the NGINX Unprivileged Docker images build and run correctly on all supported architectures on an unprivileged environment (check out the README for more details)
  • I have updated any relevant documentation (README)

@alessfg alessfg force-pushed the remove-old-images branch 2 times, most recently from 90e4eee to cce5f3a Compare March 25, 2025 15:44
@alessfg alessfg requested a review from thresheek March 25, 2025 15:44
@alessfg alessfg self-assigned this Mar 25, 2025
@alessfg alessfg added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Mar 25, 2025
@alessfg alessfg linked an issue Mar 25, 2025 that may be closed by this pull request
@alessfg alessfg added bug Something isn't working and removed enhancement New feature or request labels Mar 25, 2025
@alessfg alessfg force-pushed the remove-old-images branch 4 times, most recently from b2e2bb3 to 238165d Compare March 26, 2025 12:22
@alessfg alessfg force-pushed the main branch 3 times, most recently from 09368f7 to 25a2b8d Compare March 26, 2025 12:59
alessfg added 3 commits March 26, 2025 14:00
Co-Authored-By: Alessandro Fael Garcia <alessfg@hotmail.com>
Co-Authored-By: Alessandro Fael Garcia <alessfg@hotmail.com>
Co-Authored-By: Alessandro Fael Garcia <alessfg@hotmail.com>
@alessfg alessfg force-pushed the remove-old-images branch from 2766a9e to 7a83e70 Compare March 26, 2025 13:00
@alessfg alessfg merged commit 930b611 into main Mar 26, 2025
12 of 16 checks passed
@alessfg alessfg deleted the remove-old-images branch March 26, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Digest immutability issue with quay.io/nginx/nginx-unprivileged image

3 participants