Fix error with lift method

[smac89]

fixes #161

The error was:

Class 'Actions' incorrectly extends base class 'Observable<Action>'.
  Types of property 'lift' are incompatible.
    Type '(operator: Operator<any, Action>) => Observable<Action>' is not assignable to type '<R>(operator: Operator<Action, R>) => Observable<R>'.
      Types of parameters 'operator' and 'operator' are incompatible.
        Type 'Operator<Action, R>' is not assignable to type 'Operator<any, Action>'.
          Type 'R' is not assignable to type 'Action'.

[smac89]

There is another error I noticed, but I think this has more to do with rxjs and specifically typescript 5.4.1:

Class 'Subject<T>' incorrectly extends base class 'Observable<T>'.
  Types of property 'lift' are incompatible.
    Type '<R>(operator: Operator<T, R>) => Observable<T>' is not assignable to type '<R>(operator: Operator<T, R>) => Observable<R>'.
      Type 'Observable<T>' is not assignable to type 'Observable<R>'.
        Type 'T' is not assignable to type 'R'.

This can be fixed by adding "noStrictGenericChecks": true, to tsconfig. Thanks to this helpful hint

[rernens]

@smac89

rather than using « noStrictGenericChecks: true » which is not recommended, until rxjs is fixed create a file in in your project and paste into it the following code. It will be picked by the compiler and will fix the issue.

// augmentations.ts
import {Operator} from 'rxjs/Operator';
import {Observable} from 'rxjs/Observable';

declare module 'rxjs/Subject' {
  interface Subject<T> {
    lift<R>(operator: Operator<T, R>): Observable<R>;
  }
}

waiting for your fix to be included in @ngrx/effects to address the first issue.

Thanks

[isaacplmann]

@brandonroberts @MikeRyanDev Please merge this PR so that @ngrx/effects can work with Typescript 2.4.1+. rxjs fixed their issue last night. This PR would make it so that you don't need any workarounds any more.

[rernens]

@smac89 @isaacplmann

I confirm that rxjs 5.4.2 fixes the issue on their part.

your fix need to be merged !

[isaacplmann]

Thanks!

…

On Jul 5, 2017 6:11 PM, "Brandon" ***@***.***> wrote: Merged #163 <#163>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#163 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0lQO7srGzY0-EbayKvmakujl0aLSC2ks5sLAokgaJpZM4OKEeV> .

[rernens]

@brandonroberts @MikeRyanDev

thanks for merging this.

Any idea when npm will reflect it ?