fix(signals): drop assertUniqueStoreMembers in production (#4953)

Author: arturovt

modules/signals/src/signal-store-assertions.ts

@@ -1,15 +1,9 @@
 import { InnerSignalStore } from './signal-store-models';
 
-declare const ngDevMode: unknown;
-
 export function assertUniqueStoreMembers(
   store: InnerSignalStore,
   newMemberKeys: Array<string | symbol>
 ): void {
-  if (typeof ngDevMode === 'undefined' || !ngDevMode) {
-    return;
-  }
-
   const storeMembers = {
     ...store.stateSignals,
     ...store.props,

modules/signals/src/with-linked-state.ts

@@ -86,7 +86,9 @@ export function withLinkedState<
       ...store.props,
     });
     const stateKeys = Reflect.ownKeys(linkedState);
-    assertUniqueStoreMembers(store, stateKeys);
+    if (typeof ngDevMode !== 'undefined' && ngDevMode) {
+      assertUniqueStoreMembers(store, stateKeys);
+    }
     const stateSource = store[STATE_SOURCE] as SignalsDictionary;
     const stateSignals = {} as SignalsDictionary;
 

modules/signals/src/with-methods.ts

@@ -30,7 +30,9 @@ export function withMethods<
       ...store.props,
       ...store.methods,
     });
-    assertUniqueStoreMembers(store, Reflect.ownKeys(methods));
+    if (typeof ngDevMode !== 'undefined' && ngDevMode) {
+      assertUniqueStoreMembers(store, Reflect.ownKeys(methods));
+    }
 
     return {
       ...store,

modules/signals/src/with-props.ts

@@ -28,7 +28,9 @@ export function withProps<
       ...store.props,
       ...store.methods,
     });
-    assertUniqueStoreMembers(store, Reflect.ownKeys(props));
+    if (typeof ngDevMode !== 'undefined' && ngDevMode) {
+      assertUniqueStoreMembers(store, Reflect.ownKeys(props));
+    }
 
     return {
       ...store,

modules/signals/src/with-state.ts

@@ -34,7 +34,9 @@ export function withState<State extends object>(
     ) as Record<string | symbol, unknown>;
     const stateKeys = Reflect.ownKeys(state);
 
-    assertUniqueStoreMembers(store, stateKeys);
+    if (typeof ngDevMode !== 'undefined' && ngDevMode) {
+      assertUniqueStoreMembers(store, stateKeys);
+    }
 
     const stateSource = store[STATE_SOURCE] as Record<
       string | symbol,