Skip to content

Conversation

@mjohanse-emr
Copy link
Collaborator

@mjohanse-emr mjohanse-emr commented Oct 19, 2025

What does this Pull Request accomplish?

  • Augment the metadata test to include all green/blue boxes and include extensions for each that allow it.
  • Add tests for publishing batch measurements.
  • Add tests for publishing conditions
  • Add tests for publishing batch conditions

Why should this Pull Request be merged?

Implements part of AB#3187182

What testing has been done?

New unit tests added. Unit tests pass. mypy, pyright, styleguide.

…service

Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
@mjohanse-emr mjohanse-emr marked this pull request as ready for review October 19, 2025 18:42
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
@mjohanse-emr mjohanse-emr changed the title Fill out the rest of the metadata test functionality and add publish batch tests Fill out the rest of the metadata test functionality and add publish batch/condition tests Oct 20, 2025
Copy link
Collaborator

@dixonjoel dixonjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

Copy link
Contributor

@hunter-ni hunter-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with suggestions

Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
@mjohanse-emr mjohanse-emr merged commit e129eac into main Oct 20, 2025
21 checks passed
@mjohanse-emr mjohanse-emr deleted the users/mjohanse/acceptance_tests2 branch October 20, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants