Skip to content

noqa comments are overly lenient #250

@bkeryan

Description

@bkeryan

Bug Report

ni-measurementlink-python's noqa comments omit the colon, which causes them to ignore all errors. The correct syntax is # noqa: N802, etc.

https://www.alpharithms.com/noqa-python-501210/ says

Multiple codes can be given, separated by a comma. The noqa token is case insensitive, the colon before the list of codes is required otherwise the part after noqa is ignored

Repro or Code Sample

PS D:\dev\measurementlink-python> rg "# noqa:"
PS D:\dev\measurementlink-python> rg "# noqa "
tests\utilities\fake_discovery_service.py
14:    def RegisterService(self, request):  # noqa N802:inherited method names-autogen baseclass
22:    def UnregisterService(self, request):  # noqa N802:inherited method names-autogen baseclass
30:    def RegisterService(self, request):  # noqa N802:inherited method names-autogen baseclass
34:    def UnregisterService(self, request):  # noqa N802:inherited method names-autogen baseclass

ni_measurementlink_service\__init__.py
4:from .measurement.info import DataType  # noqa F401, declaring API
5:from .measurement.info import MeasurementInfo  # noqa F401, declaring API
6:from .measurement.info import ServiceInfo  # noqa F401, declaring API
7:from .measurement.service import MeasurementService  # noqa F401, declaring API
9:from ni_measurementlink_service import session_management  # noqa F401, declaring API

ni_measurementlink_service\_internal\grpc_servicer.py
128:    def GetMetadata(self, request, context):  # noqa N802:inherited method names-autogen baseclass
180:    def Measure(self, request, context):  # noqa N802:inherited method names-autogen baseclass

Expected Behavior

noqa comments ignore specific errors.

Current Behavior

noqa comments ignore all errors.

AB#2377672

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions