-
Notifications
You must be signed in to change notification settings - Fork 19
Add Service Annotation Support #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The discovery_service.proto changes aren't expected to go into ASW until the release branch is made. So we should wait to check these in until Curtis' changes go in, right? |
Yes, I am not planning to submit. |
#292 changes the codegen script. You will need to rerun it. |
de3714d
to
c545341
Compare
FYI, I created a releases/1.1 branch and updated main to version 1.2.0-dev0 in order to unblock these PRs. |
...ntlink_service/_internal/stubs/ni/measurementlink/measurement/v1/measurement_service_pb2.pyi
Outdated
Show resolved
Hide resolved
Both Joel and I have approved this, so please merge it. If you don't have access, let us know. |
TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.
What does this Pull Request accomplish?
Why should this Pull Request be merged?
AB#2408662
What testing has been done?
Open Issues