Fix double quotes on Annotations #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpachecoNI
requested review from
bkeryan,
csjall,
dixonjoel,
mshafer-NI,
nstokes-nati and
pbirkhol-ni
as code owners
gpachecoNI
requested review from
DelpireNI,
bkeryan and
cumitche
and removed request for
DelpireNI,
bkeryan,
csjall,
dixonjoel,
mshafer-NI,
nstokes-nati and
pbirkhol-ni
bkeryan
requested changes
Jul 19, 2023
cumitche
approved these changes
Jul 19, 2023
bkeryan
approved these changes
Jul 19, 2023
bkeryan
reviewed
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
The problem happened because - our Annotations are not all strings we allowed arrays for Tags and wanted to allow customers to add dictionaries too. I am using "json.dumps" to help manage that, but the problem is that it also adds quotes to the strings. I tried multiple fixes but this was the simplest I can come up.
Why should this Pull Request be merged?
We do not want to display the description or the Title with double quotes.
What testing has been done?
Fix and reran tests.
Manually look at the example: