Skip to content

Conversation

@bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Sep 19, 2023

What does this Pull Request accomplish?

Update check_nims workflow to generate API reference documentation and check for errors.

Upgrade to latest documentation tools.

Fix or suppress all Sphinx errors and warnings.

Why should this Pull Request be merged?

Help developers avoid using invalid markup in docstrings.

What testing has been done?

None.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

Test Results

     12 files  ±0       12 suites  ±0   2m 4s ⏱️ +4s
   198 tests ±0     169 ✔️ ±0    29 💤 ±0  0 ±0 
2 364 runs  ±0  2 016 ✔️ ±0  348 💤 ±0  0 ±0 

Results for commit ad79948. ± Comparison against base commit e20a9c3.

♻️ This comment has been updated with latest results.

Both the "Attributes:" section and autoapi are generating documentation for NamedTuple fields, which leads to warnings like this:

WARNING: duplicate object description of ni_measurementlink_service._internal.parameter.metadata.ParameterMetadata.display_name, other instance in autoapi/ni_measurementlink_service/_internal/parameter/metadata/index, use :noindex: for one of them
ERROR: Unexpected indentation.
WARNING: Block quote ends without a blank line; unexpected unindent.
@bkeryan bkeryan changed the title workflows: Check documentation in check_nims workflows: Check documentation in check_nims and fix Sphinx errors/warnings Sep 19, 2023
Copy link
Collaborator

@mshafer-NI mshafer-NI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bkeryan bkeryan merged commit d83e46f into main Sep 20, 2023
@bkeryan bkeryan deleted the users/bkeryan/check-docs branch September 20, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants