service: Add SessionManagementClient to MeasurementService and rework initialization code #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… possible Use lazy initialization for DiscoveryClient and GrpcChannelPool so they can be reinitialized after close_service(). Initialize GrpcService in host_service() and destroy it in close_service(). Deprecate the public grpc_service property and replace with a public service_location property.
bkeryan
requested review from
csjall,
dixonjoel,
mshafer-NI,
nstokes-nati and
pbirkhol-ni
as code owners
dixonjoel
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add a
session_management_clientproperty to theMeasurementServiceobject, which lazily constructs aSessionManagementClientand caches it.Rework initialization code:
DiscoveryClient: lazily create stub and allow injecting aGrpcChannelPool.SessionManagementClient: lazily create stub, allow injecting aDiscoveryClientandGrpcChannelPool, and automatically resolve service.MeasurementService:DiscoveryClient.GrpcServicecreation untilhost_service()is called.close_service()to clear lazily created objects, in order to allow reusing theMeasurementServiceobject.grpc_serviceproperty because it leaks implementation details.service_locationproperty as a replacement forgrpc_servicethat uses public types.The examples will be updated in AB#2527580.
Why should this Pull Request be merged?
Provide a simple, official API for creating the session management client, to replace the
create_session_management_clientfunction in_helpers.py.Prepare to inject a
DiscoveryClientandGrpcChannelPoolinto theReservationclasses to support improved session management APIs.What testing has been done?
Ran
poetry run pytest -vManually tested
nidcpower_source_dc_voltageandsample_measurementwith debug logging (-vv) enabled.