service: Clean up service_manager.py #396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
service_manager.py:portattribute and replace it withservice_locationservice.py:MeasurementServiceto useservice_locationinstead ofportDiscoveryClientinstead of borrowingGrpcService'sDiscoveryClientWhy should this Pull Request be merged?
Hide internal implementation details. The entire
GrpcServiceclass is an internal implementation detail, but we didn't make that clear before, so it's better to have a deprecation period before we break compatibility.Don't assume the server has only one port.
What testing has been done?
Ran
poetry run pytest -v