[releases/1.2] Importing nidcpower.session into output voltage measurement (#399) #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replacing _SessionBase with Session in Output Voltaget Measurement example. Signed-off-by: Chris Delpire <chris.delpire@ni.com> * Switching back to _SessionBase and adding import statement to fix issue. * importing nidcpower.session and fixing type hint. Signed-off-by: Chris Delpire <chris.delpire@ni.com> --------- Signed-off-by: Chris Delpire <chris.delpire@ni.com>
DelpireNI
requested review from
bkeryan,
csjall,
dixonjoel,
mshafer-NI,
nstokes-nati and
pbirkhol-ni
as code owners
bkeryan
approved these changes
Sep 25, 2023
dixonjoel
deleted the
users/cdelpire/cherry-pick-output-voltage-measurement-example-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Cherry-pick fix for output voltage measurement.
Original PR: (#399)
Why should this Pull Request be merged?
Output voltage measurement will not run successfully in 1.2 release if we do not submit this fix.
What testing has been done?
None