refactor: decouple multiplexer initialize APIs from BaseReservation to MultiplexerSessionContainer class #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaseelan-james
requested review from
bkeryan,
csjall,
dixonjoel,
mshafer-NI and
nstokes-nati
as code owners
jayaseelan-james
changed the title
SowmyaRavee
approved these changes
Feb 21, 2024
bkeryan
requested changes
Feb 21, 2024
bkeryan
reviewed
Feb 21, 2024
1 task
vigkre
approved these changes
Feb 22, 2024
bkeryan
approved these changes
Feb 23, 2024
jayaseelan-james
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Moves all the multiplexer-related properties and the initialize APIs to a separate class.
AB#2649594
Why should this Pull Request be merged?
The multiplexer initialize APIs must be decoupled from the
BaseReservationto enable independent multiplexer initialization in TestStand fixtures.What testing has been done?
Updated the existing tests.