Skip to content

Pyright configuration excludes all generated files #81

@bkeryan

Description

@bkeryan

Bug Report

This project's Pyright configuration excludes all protoc-generated files.

PS C:\dev\ni-apis-python\packages\ni.measurementlink.pinmap.v1.proto> rg "^exclude =.*pb2" C:\dev\ni-apis-python\packages\
C:\dev\ni-apis-python\packages\ni.protobuf.types\pyproject.toml
98:exclude = ["**/*_pb2_grpc.py", "**/*_pb2_grpc.pyi", "**/*_pb2.py", "**/*_pb2.pyi"]

C:\dev\ni-apis-python\packages\ni.grpcdevice.v1.proto\pyproject.toml
94:exclude = ["**/*_pb2_grpc.py", "**/*_pb2_grpc.pyi", "**/*_pb2.py", "**/*_pb2.pyi","src/**/__init__.py*"]

C:\dev\ni-apis-python\packages\ni.measurementlink.measurement.v1.proto\pyproject.toml
112:exclude = ["**/*_pb2_grpc.py", "**/*_pb2_grpc.pyi", "**/*_pb2.py", "**/*_pb2.pyi", "src/ni/measurementlink/measurement/v1/**/__init__.py*"]

C:\dev\ni-apis-python\packages\ni.measurementlink.discovery.v1.proto\pyproject.toml
92:exclude = ["**/*_pb2_grpc.py", "**/*_pb2_grpc.pyi", "**/*_pb2.py", "**/*_pb2.pyi", "src/ni/measurementlink/discovery/v1/**/__init__.py*"]

C:\dev\ni-apis-python\packages\ni.measurementlink.measurement.v2.proto\pyproject.toml
112:exclude = ["**/*_pb2_grpc.py", "**/*_pb2_grpc.pyi", "**/*_pb2.py", "**/*_pb2.pyi", "src/ni/measurementlink/measurement/v2/**/__init__.py*"]

C:\dev\ni-apis-python\packages\ni.panels.v1.proto\pyproject.toml
91:exclude = ["**/*_pb2_grpc.py", "**/*_pb2_grpc.pyi", "**/*_pb2.py", "**/*_pb2.pyi"]

C:\dev\ni-apis-python\packages\ni.measurementlink.sessionmanagement.v1.proto\pyproject.toml
107:exclude = ["**/*_pb2_grpc.py", "**/*_pb2_grpc.pyi", "**/*_pb2.py", "**/*_pb2.pyi", "src/ni/measurementlink/sessionmanagement/v1/**/__init__.py*"]

C:\dev\ni-apis-python\packages\ni.measurementlink.proto\pyproject.toml
94:exclude = ["**/*_pb2_grpc.py", "**/*_pb2_grpc.pyi", "**/*_pb2.py", "**/*_pb2.pyi", "src/ni/measurementlink/**/__init__.py*"]

Repro or Code Sample

Expected Behavior

Pyright type-checks the files.

Current Behavior

Pyright type-checks zero files.

PS C:\dev\ni-apis-python\packages\ni.measurementlink.pinmap.v1.proto> poetry run pyright
WARNING: there is a new pyright version available (v1.1.403 -> v1.1.404).
Please install the new version or set PYRIGHT_PYTHON_FORCE_VERSION to `latest`

File or directory "c:\Dev\ni-apis-python\packages\ni.measurementlink.pinmap.v1.proto\tests" does not exist.
0 errors, 0 warnings, 0 informations

Possible Solution

Update the Pyright excludes and address the errors and warnings.

Context

Reviewing #80

Your Environment

N/A

AB#3237959

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtriageNew issue that needs to be reviewed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions