Skip to content

Conversation

@dixonjoel
Copy link
Collaborator

@dixonjoel dixonjoel commented Sep 4, 2025

What does this Pull Request accomplish?

Adds the ni.measurementlink.pinmap.v1.client package with docs and unit tests.

Why should this Pull Request be merged?

More shared code from measurement-plugin-python. Will be consumed and removed from there once published.

What testing has been done?

A couple of unit tests came over with the code and will test while consuming in measurement-plugin-python.

@dixonjoel dixonjoel changed the title Users/jdixon/add pinmap v1 client package Add the ni.measurementlink.pinmap.v1.client package Sep 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

Test Results

   76 files  +10     76 suites  +10   1m 49s ⏱️ +5s
  186 tests + 2    184 ✅ ± 0   2 💤 + 2  0 ❌ ±0 
1 844 runs  +20  1 814 ✅ ± 0  30 💤 +20  0 ❌ ±0 

Results for commit 623a4ab. ± Comparison against base commit 034c829.

♻️ This comment has been updated with latest results.

@dixonjoel dixonjoel marked this pull request as ready for review September 5, 2025 14:07
@dixonjoel dixonjoel merged commit 4fa0d5b into main Sep 5, 2025
83 checks passed
@dixonjoel dixonjoel deleted the users/jdixon/add-pinmap-v1-client-package branch September 5, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants