Update to latest API in ni-apis and regenerate stubs to match #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dixonjoel
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project's dependency on ni-apis to a specific commit and regenerates Python stub files to maintain compatibility with API changes. The update includes new gRPC service methods and field naming improvements.
Key changes:
- Added
CreateFromJsonDocumentRPC method to the metadata service for bulk metadata creation from JSON documents - Renamed fields in data service for improved clarity (
condition_name→name,type→condition_type,measurement_name→name) - Updated documentation comments for several message fields
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| third_party/ni-apis | Updated subproject commit reference to latest version |
| packages/ni.measurements.metadata.v1.proto/src/ni/measurements/metadata/v1/metadata_store_service_pb2_grpc/init.pyi | Added type stubs for new CreateFromJsonDocument method in stub and servicer classes |
| packages/ni.measurements.metadata.v1.proto/src/ni/measurements/metadata/v1/metadata_store_service_pb2_grpc/init.py | Added CreateFromJsonDocument RPC method implementation to service stub and servicer |
| packages/ni.measurements.metadata.v1.proto/src/ni/measurements/metadata/v1/metadata_store_service_pb2/init.pyi | Added type definitions for CreateFromJsonDocumentRequest and CreateFromJsonDocumentResponse |
| packages/ni.measurements.metadata.v1.proto/src/ni/measurements/metadata/v1/metadata_store_service_pb2/init.py | Updated serialized descriptor and metadata for new message types |
| packages/ni.measurements.metadata.v1.proto/src/ni/measurements/metadata/v1/metadata_store_pb2/init.pyi | Simplified product field documentation in SoftwareItem |
| packages/ni.measurements.data.v1.proto/src/ni/measurements/data/v1/data_store_service_pb2/init.pyi | Renamed fields for clarity in PublishCondition and PublishMeasurement request classes |
| packages/ni.measurements.data.v1.proto/src/ni/measurements/data/v1/data_store_service_pb2/init.py | Updated serialized descriptor offsets to reflect field name changes |
| packages/ni.measurements.data.v1.proto/src/ni/measurements/data/v1/data_store_pb2/init.pyi | Simplified name field documentation in TestResult |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jfriedri-ni
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Update to this commit in ni-apis. Regenerate Python stubs to match this so the build will pass.
Why should this Pull Request be merged?
Precursor to releasing
metadata.proto,data.proto,metadata.clientanddata.clientpackages to get them up-to-date.What testing has been done?
PR