Skip to content

Conversation

@dixonjoel
Copy link
Collaborator

What does this Pull Request accomplish?

Makes data.proto pyproject.toml depend on the just-released version of metadata.proto.

Why should this Pull Request be merged?

Precursor to releasing data.proto.

What testing has been done?

poetry lock and poetry install locally. PR

Copilot AI review requested due to automatic review settings November 14, 2025 20:38
Copilot finished reviewing on behalf of dixonjoel November 14, 2025 20:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the dependency version of ni-measurements-metadata-v1-proto from 0.1.0.dev4 to 0.1.0.dev5 in preparation for releasing the data.proto package.

  • Updated minimum version requirement for ni-measurements-metadata-v1-proto dependency
  • Regenerated poetry.lock with updated dependency resolution

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/ni.measurements.data.v1.proto/pyproject.toml Updated ni-measurements-metadata-v1-proto minimum version constraint from >=0.1.0.dev4 to >=0.1.0.dev5
packages/ni.measurements.data.v1.proto/poetry.lock Updated locked version of ni-measurements-metadata-v1-proto to 0.1.0.dev6 and regenerated content hash

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

Test Results

  120 files  ±0    120 suites  ±0   3m 29s ⏱️ +13s
  247 tests ±0    245 ✅ ±0   2 💤 ±0  0 ❌ ±0 
2 470 runs  ±0  2 440 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 844b53a. ± Comparison against base commit 97e3a3c.

♻️ This comment has been updated with latest results.

@dixonjoel dixonjoel closed this Nov 14, 2025
@dixonjoel dixonjoel reopened this Nov 14, 2025
@dixonjoel dixonjoel merged commit fc340d9 into main Nov 14, 2025
685 checks passed
@dixonjoel dixonjoel deleted the users/jdixon/update-data-proto-metadata-dependency branch November 14, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants