Add a workflow step to run the grpc_generator unit tests. #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
…ows. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
bkeryan
reviewed
Jul 17, 2025
added 7 commits
July 17, 2025 16:47
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
… is sufficient. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
bkeryan
requested changes
Jul 18, 2025
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
bkeryan
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add a workflow step that runs the unit tests for the
grpc_generatorpython package. To do this, I had to add a second input to therun_and_upload_unit_testsaction that allows for a path that is not in the "packages" subfolder.A couple of things I had to update to get this working properly:
unitfolder since that's what the github action expects.ifstatement to the grpc_generator tests to only run them on the minimum supported version (3.11 in this case).Why should this Pull Request be merged?
Implements AB#3195860
What testing has been done?
Unit tests, mypy, pyright, styleguide.
I verified that the grpc_generator unit tests ran on the 3.11 unit test jobs.