Add proto packages for measurement/v1 and measurement/v2 #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…building so we can proceed
Base automatically changed from
users/jdixon/ni-discovery-service-proto-package
to
main
August 14, 2025 20:25
…rement-proto-package
Contributor
jfriedri-ni
requested changes
Aug 14, 2025
packages/ni.measurementlink.measurement.v2.proto/docs/intro.inc
Outdated
Show resolved
Hide resolved
packages/ni.measurementlink.measurement.v2.proto/.readthedocs.yaml
Outdated
Show resolved
Hide resolved
jfriedri-ni
approved these changes
Aug 15, 2025
bkeryan
reviewed
Aug 15, 2025
...asurement.v2.proto/src/ni/measurementlink/measurement/v2/measurement_service_pb2/__init__.py
Show resolved
Hide resolved
bkeryan
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add a package with generated files from v1 measurement_service.proto and v2 measurement_service.proto
Why should this Pull Request be merged?
New package so we can remove the generated stubs from measurement-plugin-python and reference the new packages instead from this single source.
What testing has been done?
Once submitted, I'll create a pre-release of the package.