Introduce the ni.measurementlink.sessionmanagement.v1.proto package #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jfriedri-ni
requested changes
Aug 15, 2025
Collaborator
jfriedri-ni
left a comment
jfriedri-ni
left a comment
There was a problem hiding this comment.
Reset me when this is ready.
Collaborator
Author
@jfriedri-ni Checks are passing now. |
bkeryan
requested changes
Aug 15, 2025
packages/ni.measurementlink.measurement.v1.proto/docs/index.rst
Outdated
Show resolved
Hide resolved
Collaborator
|
I assume you will package this in a separate PR. |
jfriedri-ni
approved these changes
Aug 15, 2025
Collaborator
jfriedri-ni
left a comment
jfriedri-ni
left a comment
There was a problem hiding this comment.
A few mismatched package name references remain.
packages/ni.measurementlink.measurement.v1.proto/docs/intro.inc
Outdated
Show resolved
Hide resolved
packages/ni.measurementlink.sessionmanagement.v1.proto/docs/intro.inc
Outdated
Show resolved
Hide resolved
csjall
reviewed
Aug 15, 2025
bkeryan
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
The
ni.measurementlink.sessionmanagement.v1.protopackage includes the generated code for session_management_service.protoWhy should this Pull Request be merged?
Need the
session_management_service.protogenerated code as a dependency.What testing has been done?
Will publish a package for testing after submission.