Use the new ni.measurementlink.proto package in the ni.measurementlink.measurement.v*.proto packages #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bkeryan
requested changes
Aug 15, 2025
packages/ni.measurementlink.measurement.v1.proto/pyproject.toml
Outdated
Show resolved
Hide resolved
dixonjoel
changed the title
jfriedri-ni
approved these changes
Aug 18, 2025
...ni.measurementlink.measurement.v1.proto/tests/unit/test_ni_measurementlink_measurement_v1.py
Outdated
Show resolved
Hide resolved
...ni.measurementlink.measurement.v2.proto/tests/unit/test_ni_measurementlink_measurement_v2.py
Outdated
Show resolved
Hide resolved
packages/ni.measurementlink.measurement.v2.proto/tests/__init__.py
Outdated
Show resolved
Hide resolved
bkeryan
requested changes
Aug 18, 2025
packages/ni.measurementlink.measurement.v2.proto/pyproject.toml
Outdated
Show resolved
Hide resolved
packages/ni.measurementlink.measurement.v1.proto/pyproject.toml
Outdated
Show resolved
Hide resolved
packages/ni.measurementlink.measurement.v1.proto/tests/__init__.py
Outdated
Show resolved
Hide resolved
bkeryan
approved these changes
Aug 18, 2025
Collaborator
bkeryan
left a comment
bkeryan
left a comment
There was a problem hiding this comment.
Approved, once you get the __init__.py docstrings sorted out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Now that [ni.measurementlink.proto] is available as a package, pull it in to the measurement.v1 and measurement.v2 dependencies. Also include a local path to the ni.measurementlink.proto package for when we want to test with that source.
Why should this Pull Request be merged?
Ultimately, we want to use these packages in measurement-plugin-python so we can single-source these generated stubs in packages.
What testing has been done?
Build passes. Will use these packages in measurement-plugin-python to test.