Fix session.proto namespace and regenerate python code #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfriedri-ni
approved these changes
Aug 21, 2025
Contributor
bkeryan
approved these changes
Aug 21, 2025
dixonjoel
deleted the
users/jdixon/fix-sessionmanagement-session-reference
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Fixes the namespace of our session.proto file and regenerates the stubs for ni.grpcdevice.v1.proto.
Why should this Pull Request be merged?
I had mistakenly changed the package namespace to ni.grpcdevice.v1. But it needs to be nidevice_grpc for backwards compatibility.
What testing has been done?
Will produce a new version of the package and test with that after submission.