Skip to content

Conversation

marcoskirsch
Copy link
Member

[X] This contribution adheres to [CONTRIBUTING.md]

What does this Pull Request accomplish?

Cleans up how we handle errors.

  • Decouples Eror classes from session
  • Simplifies Session method for getting error descriptions
  • Improves handle_error function
    • No longer prefixed with _
    • Knows how to handle warnings, simplifies generated code.
    • Generated code no longer calls private functions in errors.

Why should this Pull Request be merged?

Improves error handling code.

What testing has been done?

Unit tests and some local tests were run.

@marcoskirsch
Copy link
Member Author

Diff is wrong, will re-do.

@coveralls
Copy link

coveralls commented Sep 1, 2017

Coverage Status

Coverage increased (+0.1%) to 61.738% when pulling 2123fbe on new/cleanup-error-handling into 258beb0 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 61.738% when pulling 2123fbe on new/cleanup-error-handling into 258beb0 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants