Skip to content

Conversation

@mikeprosserni
Copy link
Collaborator

What does this Pull Request accomplish?

Single-source typing backports in a single submodule.

Why should this Pull Request be merged?

Don't repeat yourself.

Avoid accidentally depending on typing_extensions at run time.

What testing has been done?

ran lint, mypy, and tests on Python 3.9.13

@mikeprosserni mikeprosserni marked this pull request as ready for review May 1, 2025 18:54
@mikeprosserni mikeprosserni requested a review from csjall as a code owner May 1, 2025 18:54
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2025

Test Results

10 files  ±0  10 suites  ±0   8s ⏱️ -1s
 6 tests ±0   6 ✅ ±0  0 💤 ±0  0 ❌ ±0 
60 runs  ±0  60 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d86c856. ± Comparison against base commit 173ee7f.

♻️ This comment has been updated with latest results.

@mikeprosserni mikeprosserni requested a review from bkeryan May 1, 2025 19:01
@mikeprosserni mikeprosserni requested a review from bkeryan May 2, 2025 14:45
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

@mikeprosserni mikeprosserni merged commit 83c56f0 into main May 2, 2025
13 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/typing-refactor branch May 2, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants