Skip to content

Conversation

@mikeprosserni
Copy link
Collaborator

@mikeprosserni mikeprosserni commented Aug 26, 2025

What does this Pull Request accomplish?

I did the pyproject.toml migration wrong the first time, which led to a bunch of extra "Requires-Dist"s in the METADATA.

To fix this, I've reverted this change and re-done the migration using poetry-plugin-migrate instead.

Here are the specific commands and choices:

c:\dev\fireserp\nipanel-python>poetry migrate

Checking the current project: nipanel (0.1.0)

Warning: [tool.poetry.name] is deprecated. Use [project.name] instead.
Warning: [tool.poetry.version] is set but 'version' is not in [project.dynamic]. If it is static use [project.version]. If it is dynamic, add 'version' to [project.dynamic].
If you want to set the version dynamically via `poetry build --local-version` or you are using a plugin, which sets the version dynamically, you should define the version in [tool.poetry] and add 'version' to [project.dynamic].
Warning: [tool.poetry.description] is deprecated. Use [project.description] instead.
Warning: [tool.poetry.readme] is set but 'readme' is not in [project.dynamic]. If it is static use [project.readme]. If it is dynamic, add 'readme' to [project.dynamic].
If you want to define multiple readmes, you should define them in [tool.poetry] and add 'readme' to [project.dynamic].
Warning: [tool.poetry.authors] is deprecated. Use [project.authors] instead.

Creating backup at c:\dev\fireserp\nipanel-python\pyproject.bak.toml

Migrating pyproject.toml...

[tool.poetry.version] found. If you want to set the version dynamically via poetry build --local-version or you are using a plugin, which sets the version dynamically, you should use dynamic versioning that keeps 'version' in [tool.poetry] and adds 'version' to [project.dynamic]. Otherwise, 'version' will be moved to [project].
Keeps Poetry managing version in [tool.poetry] with dynamic versioning? (yes/no) [yes] no

How to migrate [tool.poetry.dependencies.python]? [Copy value to [project.requires-python]]:
 [ 0] Move to [project.requires-python]
 [ 1] Add `requires-python` to [project.dynamic]
 [ 2] Copy value to [project.requires-python]
 [ 3] No migration and keep it as-is
 > 3

[tool.poetry.dependencies] found. `dependencies` will be added to [project.dynamic] if you want to keep it in [tool.poetry].
Keeps dependencies in [tool.poetry]? (yes/no) [no] yes

Update [tool.poetry.requires-poetry] to which constraint? [No update]:
 [ 0] >=2.0
 [ 1] >=2.0,<3.0
 [ 2] >=2.0.0
 [ 3] >=2.0.0,<3.0.0
 [ 4] No update
 > 1

Generated file

Writing pyproject.toml

It is recommended to run poetry lock && poetry install after migration.

(I subsequently reordered some lines in pyproject.toml to make the diff clearer)

Why should this Pull Request be merged?

#143

What testing has been done?

I ran the linter, mypy, and autotests. I also interactively tested the nidaqmx_continuous_analog_input example.

Here's the new METADATA:

c:\dev\fireserp\nipanel-python\dist>type extracted_wheel\nipanel-0.1.0.dist-info\METADATA
Metadata-Version: 2.3
Name: nipanel
Version: 0.1.0
Summary: NI Panel Python API
Author: NI
Author-email: opensource@ni.com
Requires-Python: >=3.9, !=2.7.*, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, !=3.5.*, !=3.6.*, !=3.7.*, !=3.8.*
Classifier: Programming Language :: Python :: 3
Classifier: Programming Language :: Python :: 3.9
Classifier: Programming Language :: Python :: 3.10
Classifier: Programming Language :: Python :: 3.11
Classifier: Programming Language :: Python :: 3.12
Classifier: Programming Language :: Python :: 3.13
Requires-Dist: debugpy (>=1.8.1)
Requires-Dist: grpcio (>=1.49.0,<2.0)
Requires-Dist: ni-measurement-plugin-sdk (>=2.4.0dev1)
Requires-Dist: ni-panels-v1-proto (>=0.1.0dev1)
Requires-Dist: ni-protobuf-types (>=0.1.0dev3)
Requires-Dist: nitypes (>=0.1.0dev8)
Requires-Dist: numpy (>=1.22)
Requires-Dist: protobuf (>=4.21)
Requires-Dist: streamlit (>=1.24)
Requires-Dist: typing-extensions (>=4.13.2)
Description-Content-Type: text/markdown

# nipanel-python
Source for the nipanel python package

@mikeprosserni mikeprosserni requested a review from csjall as a code owner August 26, 2025 15:05
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2025

Test Results

   10 files  ±0     10 suites  ±0   23s ⏱️ -8s
  251 tests ±0    251 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 460 runs  ±0  2 460 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 67ad3b2. ± Comparison against base commit 7ed53fa.

♻️ This comment has been updated with latest results.

@bkeryan
Copy link
Collaborator

bkeryan commented Aug 26, 2025

@mikeprosserni mikeprosserni linked an issue Aug 26, 2025 that may be closed by this pull request
@mikeprosserni mikeprosserni requested a review from bkeryan August 26, 2025 15:16
@mikeprosserni mikeprosserni requested a review from bkeryan August 26, 2025 17:10
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

@mikeprosserni mikeprosserni merged commit 56c166f into main Aug 26, 2025
14 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/poetry-plugin-migrate branch August 26, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev dependencies should not be extras

3 participants