-
Couldn't load subscription status.
- Fork 0
Change pyproject.toml extras back to poetry dependencies #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Combined diff of both the previous PR and this one: https://github.com/ni/nipanel-python/compare/2e3ec2a891047b12ef37cce5991b19eef3d2a097..users/mprosser/poetry-plugin-migrate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestions
What does this Pull Request accomplish?
I did the pyproject.toml migration wrong the first time, which led to a bunch of extra "Requires-Dist"s in the METADATA.
To fix this, I've reverted this change and re-done the migration using poetry-plugin-migrate instead.
Here are the specific commands and choices:
(I subsequently reordered some lines in pyproject.toml to make the diff clearer)
Why should this Pull Request be merged?
#143
What testing has been done?
I ran the linter, mypy, and autotests. I also interactively tested the nidaqmx_continuous_analog_input example.
Here's the new METADATA: