Skip to content

Conversation

@mikeprosserni
Copy link
Collaborator

What does this Pull Request accomplish?

This PR updates the proto file to remove the Disconnect() method, and rename the Connect() method to OpenPanel(). The panel and the tests are updated accordingly. Since there's no longer a Disconnect(), the panel no longer supports the with statement.

Why should this Pull Request be merged?

The .proto file needs to match the .proto file in ASW: https://ni.visualstudio.com/DevCentral/_git/ASW/pullrequest/961874

What testing has been done?

Ran the linter, mypy, and the tests.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

Test Results

10 files  ± 0  10 suites  ±0   6s ⏱️ ±0s
 6 tests  -  2   6 ✅  -  2  0 💤 ±0  0 ❌ ±0 
60 runs   - 20  60 ✅  - 20  0 💤 ±0  0 ❌ ±0 

Results for commit c34baf3. ± Comparison against base commit e0b567a.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
tests.unit.test_python_panel_service_stub ‑ test___connect___gets_response
tests.unit.test_python_panel_service_stub ‑ test___disconnect___gets_response
tests.unit.test_streamlit_panel ‑ test___connected_panel___set_value___gets_same_value
tests.unit.test_streamlit_panel ‑ test___first_connect_fails___connect___gets_value
tests.unit.test_streamlit_panel ‑ test___with_panel___set_value___gets_same_value
tests.unit.test_python_panel_service_stub ‑ test___open_panel___gets_response
tests.unit.test_streamlit_panel ‑ test___first_open_panel_fails___open_panel___gets_value
tests.unit.test_streamlit_panel ‑ test___opened_panel___set_value___gets_same_value

@mikeprosserni mikeprosserni marked this pull request as ready for review May 2, 2025 15:14
@mikeprosserni mikeprosserni requested a review from csjall as a code owner May 2, 2025 15:14
@mikeprosserni mikeprosserni requested a review from bkeryan May 2, 2025 15:14
@mikeprosserni mikeprosserni merged commit 173ee7f into main May 2, 2025
13 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/proto-openpanel branch May 2, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants