Skip to content

Conversation

@mikeprosserni
Copy link
Collaborator

@mikeprosserni mikeprosserni commented Sep 30, 2025

What does this Pull Request accomplish?

This updates the nidaqmx examples to use the new task.read_waveform() and task.write_waveform() methods.

I also changed how the run and stop buttons work. Trying to use panel.get_value("run_button", False) is just not reliable, so I changed it to use panel.get_value("is_running", False) instead, and the buttons now explicitly set is_running when clicked.

I also improved error handling. Now, instead of the script ending when a DAQ error happens, the script loops back to the stopped state, with a message (taking the place of the graph) saying what the error is, so that the user can change the configuration and click Run again.

I also added filters on the channel selectors so that only compatible channels are presented.

I also made some changes to improve consistency between the three daq examples.

Why should this Pull Request be merged?

AB#3353661

What testing has been done?

Ran the three examples:

examples/nidaqmx/nidaqmx_analog_input_filtering/nidaqmx_analog_input_filtering.py

image

examples/nidaqmx/nidaqmx_analog_output_voltage/nidaqmx_analog_output_voltage.py

image

examples/nidaqmx/nidaqmx_continuous_analog_input/nidaqmx_continuous_analog_input.py

image

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

Test Results

   10 files  ±0     10 suites  ±0   25s ⏱️ ±0s
  256 tests ±0    256 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 510 runs  ±0  2 510 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 725a615. ± Comparison against base commit b17e813.

♻️ This comment has been updated with latest results.

@mikeprosserni mikeprosserni marked this pull request as ready for review October 1, 2025 19:25
@mikeprosserni mikeprosserni requested a review from csjall as a code owner October 1, 2025 19:25
@mikeprosserni mikeprosserni reopened this Oct 2, 2025
@mikeprosserni mikeprosserni reopened this Oct 2, 2025
@mikeprosserni mikeprosserni reopened this Oct 2, 2025
@mikeprosserni mikeprosserni reopened this Oct 2, 2025
@mikeprosserni mikeprosserni merged commit 12efe80 into main Oct 2, 2025
66 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/task-3353661-waveform-examples branch October 3, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants