-
Couldn't load subscription status.
- Fork 0
Add python<-->gRPC converters for AnalogWaveform and DateTime. #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
…a bintime. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Test Results 10 files ± 0 10 suites ±0 15s ⏱️ -6s Results for commit bda3e42. ± Comparison against base commit 9afcc8a. This pull request removes 2 and adds 18 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some explanatory comments to inform reviewers.
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation details I'm not sure about that I am looking to get feedback on.
|
This PR was in draft mode when I checked for PRs to review earlier, so I will review it tomorrow. |
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
…m/ni/nipanel-python into users/mjohanse/more_pb_converters
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
…etime. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
What does this Pull Request accomplish?
Creates python<-->gRPC converters for
waveform.AnalogWaveformandbintime.DateTime.Two converters created:
AnalogWaveform(python) <-->DoubleAnalogWaveform(protobuf)AnalogWaveformswith typenp.float64ExtendedPropertyDictionaryto the associated protobuf fieldattributesDateTime(python) <-->PrecisionTimestamp(protobuf)to_tupleandfrom_tuple()entrypoints fromnitypesWhy should this Pull Request be merged?
Contributes to development for AB#3161134
What testing has been done?
I added unit tests for the AnalogWaveform converter (both directions). All unit tests pass.