Skip to content

Conversation

szb640
Copy link
Contributor

@szb640 szb640 commented Sep 30, 2025

What does this Pull Request accomplish?

Changes in #34 cause self-hosted agents to run into issues, as the directory is not cleaned by GitHub Runner between runs.

Early versions of #26 proposed to use the temporary runner directory that is cleaned by the runner between runs, but due to concerns about caching and uncertainty about the order of operations during cleanup, it has been changed to the repository directory, which has its own set of issues, such as #33.

To resolve the issue, I've revisited the original approach:

  • Caching has been previously implemented to support non-uniform temporary paths.
  • Verified caching occurs before cleanup, as post steps (such as caching) are synchronously run before final cleanup.

Why should this Pull Request be merged?

  • Fixes caching on self-hosted runners.
  • Merge environment setup steps into one to reduce duplication.

What testing has been done?

  • Run on Linux containers twice with success, verified caching works.
  • Run on self-hosted Windows runner twice with success.

Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions (PR description, README.md?)

Co-authored-by: mshafer-NI <23644905+mshafer-NI@users.noreply.github.com>
@bkeryan bkeryan merged commit 9768589 into ni:main Oct 2, 2025
153 checks passed
@szb640 szb640 deleted the users/bsziksza/poetryTemp branch October 10, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants